Skip to content

Conversation

TsunamiAnt
Copy link
Contributor

@TsunamiAnt TsunamiAnt commented Aug 28, 2025

About The Pull Request

Adds the lifesaver necklace to the mining voucher as well as the mining vendor.
It's a small matchbook sized plastitanium box on a string that screams and whines and calls over radio and makes boopy noises when it's user dies. It also shows up on GPS.

It only works on lavaland.

Why It's Good For The Game

Never complain to me about being forgotten again.

Testing Photographs and Procedure

Screenshots&Videos image

dreamseeker_095o6vElMx

dreamseeker_0qUPau3sJg

image image image

Changelog

🆑
add: Added Lifesaver necklace, a death-notifier for miners.
/:cl:

@TsunamiAnt
Copy link
Contributor Author

still some bugs to iron out related to the equip and signal code, also the vendor is complaining a bad index, but I figure I'll at least get the PR up for now.

@TsunamiAnt TsunamiAnt changed the title Liversaver necklace Lifesaver necklace Aug 28, 2025
@DarnTheMarn
Copy link
Contributor

anyone want to make some bets?

1 week after this gets merged someone makes a PR that gives it to security.

IIRC Bacon pretty much had an idea for this exact thing to give to security a long ass time ago.

Copy link
Contributor

@mrmanlikesbt mrmanlikesbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute the source of livesaver.ogg

@Fronsis
Copy link

Fronsis commented Aug 28, 2025

anyone want to make some bets?

1 week after this gets merged someone makes a PR that gives it to security.

IIRC Bacon pretty much had an idea for this exact thing to give to security a long ass time ago.

You're having a stroke and mixing the Dispatch with some PR-discussion comments

Anyways, yipeee good addition for those poor souls!

Explorers could definetly use something similar( Most of the time if no one paid attention to the broadcast signal they're forgotten since it's only sent once)

@FedorPavluk
Copy link

Please add 10 seconds timer before wallmart deathrattle alert, so i could kill miner in maints.

@FedorPavluk
Copy link

I feel like miners have already more then enough survival tools as it is. Fulton packs, tracking implants (which you can use at tracking beacon for teleporter if i'm not mistaken) mandatory gps, ets. Adding something that announces that "yo theres a dead crewmember" is too much. How about instead of deathrattle, necklace would link miner to suit sensors network on station, so medical could always track their vitals. This will devalue valudhunting aspect of necklace for sure.
Also heres where i stole the idea from. tgstation/tgstation#65253

@TsunamiAnt
Copy link
Contributor Author

Please add 10 seconds timer before wallmart deathrattle alert, so i could kill miner in maints.

you get 15 seconds, and it'll make it obvious.

@TsunamiAnt
Copy link
Contributor Author

wowee guys we are clearing linters

@mrmanlikesbt mrmanlikesbt dismissed their stale review August 29, 2025 02:15

Code is fine now. Me or someone else needs to come along and review the gameplay changes

@Liver-1
Copy link
Contributor

Liver-1 commented Aug 29, 2025

If it only works on lavaland it should have a line in the item description that says something like:
"Due to the unique commlink this device has to the lavaland base comms array, it will only work on lavaland."

@TsunamiAnt
Copy link
Contributor Author

If it only works on lavaland it should have a line in the item description that says something like: "Due to the unique commlink this device has to the lavaland base comms array, it will only work on lavaland."

good call yeah

@Nakalon
Copy link
Contributor

Nakalon commented Aug 30, 2025

I feel like miners have already more then enough survival tools as it is. Fulton packs, tracking implants (which you can use at tracking beacon for teleporter if i'm not mistaken) mandatory gps, ets. Adding something that announces that "yo theres a dead crewmember" is too much. How about instead of deathrattle, necklace would link miner to suit sensors network on station, so medical could always track their vitals. This will devalue valudhunting aspect of necklace for sure.
Also heres where i stole the idea from. tgstation/tgstation#65253

I also think this is a better less powegameable solution

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a 1 minute delay instead of 15 seconds and have it repeat every minute
Make them available in medbay vendors (4 stock?) + 1 in each mining locker
Make them work on station too, as a sort of enhanced sensors

Upping the delay to a full minute gives ample time for antagonists encountering someone that is wearing one to remove it or get the fuck away from their victim.

Acting in discord like this PR puts it entirely as the miner's responsibility to be found really soured my view of this PR when you have chosen to make this item the most expensive item in the vendor, when the average miner doesn't make more than 20,000 points in a round. The station should already be checking on miners and it's ridiculous to act like it's entirely the miner's responsibility to want to be found beyond taking a GPS on top of making it so expensive.

@Rukofamicom Rukofamicom dismissed their stale review September 16, 2025 13:02

I don't care anymore, I can't understand bacon's point of view and I just don't care about this anymore. Do what he says and hopefully he'll merge it.

@TsunamiAnt
Copy link
Contributor Author

o7

the tyranny rears it's ugly head again, I shall comply obediently, yes sir.

Increases the lifesaver activation delay and introduces a shutoff mechanism for radio announcements after a certain period, while still keeping the GPS active.
This prevents constant radio spam while still allowing for location tracking.
@PowerfulBacon
Copy link
Member

My thoughts are generally as this:

  • The design of a stationside and lavaland item need to be completely different due to the relatively incompatible gameplay systems.
  • For a mechanic intended to go on the station, I'd rather have a security pager system which isn't all that useful to miners and isn't designed for mining.
  • For a mechanic intended to be used for off station roles, I'd rather have it useful for them and any changes to make it work on the station would require heavily limiting that, so z level limits is just the best solution in my opinion.

QDEL_NULL(radio)
return ..()

/obj/item/clothing/neck/necklace/lifesaver/equipped(mob/user, slot)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not account for being dropped directly without going through the hands first.

QDEL_NULL(radio)
return ..()

/obj/item/clothing/neck/necklace/lifesaver/equipped(mob/user, slot)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When unequipped or dropped, it should disable its pinging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants