-
-
Notifications
You must be signed in to change notification settings - Fork 716
Lifesaver necklace #13216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Lifesaver necklace #13216
Conversation
still some bugs to iron out related to the equip and signal code, also the vendor is complaining a bad index, but I figure I'll at least get the PR up for now. |
anyone want to make some bets? 1 week after this gets merged someone makes a PR that gives it to security. IIRC Bacon pretty much had an idea for this exact thing to give to security a long ass time ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attribute the source of livesaver.ogg
You're having a stroke and mixing the Dispatch with some PR-discussion comments Anyways, yipeee good addition for those poor souls! Explorers could definetly use something similar( Most of the time if no one paid attention to the broadcast signal they're forgotten since it's only sent once) |
Please add 10 seconds timer before wallmart deathrattle alert, so i could kill miner in maints. |
I feel like miners have already more then enough survival tools as it is. Fulton packs, tracking implants (which you can use at tracking beacon for teleporter if i'm not mistaken) mandatory gps, ets. Adding something that announces that "yo theres a dead crewmember" is too much. How about instead of deathrattle, necklace would link miner to suit sensors network on station, so medical could always track their vitals. This will devalue valudhunting aspect of necklace for sure. |
you get 15 seconds, and it'll make it obvious. |
wowee guys we are clearing linters |
Code is fine now. Me or someone else needs to come along and review the gameplay changes
If it only works on lavaland it should have a line in the item description that says something like: |
good call yeah |
I also think this is a better less powegameable solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give it a 1 minute delay instead of 15 seconds and have it repeat every minute
Make them available in medbay vendors (4 stock?) + 1 in each mining locker
Make them work on station too, as a sort of enhanced sensors
Upping the delay to a full minute gives ample time for antagonists encountering someone that is wearing one to remove it or get the fuck away from their victim.
Acting in discord like this PR puts it entirely as the miner's responsibility to be found really soured my view of this PR when you have chosen to make this item the most expensive item in the vendor, when the average miner doesn't make more than 20,000 points in a round. The station should already be checking on miners and it's ridiculous to act like it's entirely the miner's responsibility to want to be found beyond taking a GPS on top of making it so expensive.
I don't care anymore, I can't understand bacon's point of view and I just don't care about this anymore. Do what he says and hopefully he'll merge it.
o7 the tyranny rears it's ugly head again, I shall comply obediently, yes sir. |
Increases the lifesaver activation delay and introduces a shutoff mechanism for radio announcements after a certain period, while still keeping the GPS active. This prevents constant radio spam while still allowing for location tracking.
My thoughts are generally as this:
|
QDEL_NULL(radio) | ||
return ..() | ||
|
||
/obj/item/clothing/neck/necklace/lifesaver/equipped(mob/user, slot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not account for being dropped directly without going through the hands first.
QDEL_NULL(radio) | ||
return ..() | ||
|
||
/obj/item/clothing/neck/necklace/lifesaver/equipped(mob/user, slot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When unequipped or dropped, it should disable its pinging
About The Pull Request
Adds the lifesaver necklace to the mining voucher as well as the mining vendor.
It's a small matchbook sized plastitanium box on a string that screams and whines and calls over radio and makes boopy noises when it's user dies. It also shows up on GPS.
It only works on lavaland.
Why It's Good For The Game
Never complain to me about being forgotten again.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
add: Added Lifesaver necklace, a death-notifier for miners.
/:cl: